fix: sort artists case-insensitively with symbols before letters - #28
Merged
Conversation
SQLite's default ORDER BY uses byte-wise comparison, so all uppercase names sorted before any lowercase one instead of interleaving them alphabetically. Adds a shared ARTIST_NAME_ORDER_BY expression that applies NOCASE collation and groups non-alphabetic leading characters first, used consistently across the artist, album, and track queries. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A→Z→a→z→symbolsinstead of alphabetically, because SQLite's defaultORDER BYonar.nameis a byte-wise comparison.ARTIST_NAME_ORDER_BYSQL expression (db/queries/artists.rs) that appliesNOCASEcollation and groups any name starting with a digit/symbol before alphabetic names, and reuses it inalbums.rsandtracks.rsso the artist ordering stays consistent everywhere it's used.Test plan
cargo test --lib— 104 passed, including a newlist_album_artists_sorts_case_insensitively_with_symbols_before_letterstest covering mixed-case and symbol-prefixed namesScreencast.from.2026-07-08.20-35-33.mp4
🤖 Generated with Claude Code